ObjXMPP  Check-in [3d540fd517]

Overview
Comment:Don't retain the delegate to prevent a reference cycle.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 3d540fd5179ceca87257da34a4e4c37640b2cccab91166f1088e61728d1080c4
User & Date: js on 2011-10-24 18:32:44
Other Links: manifest | tags
Context
2011-11-22
22:07
Implement certificate checking. check-in: 91ee08a56a user: florob@babelmonkeys.de tags: trunk
2011-10-24
18:32
Don't retain the delegate to prevent a reference cycle. check-in: 3d540fd517 user: js tags: trunk
2011-10-04
12:54
Make use of -[OFXMLElement setStringValue:]. check-in: 1420288ed7 user: js tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Modified src/XMPPConnection.h from [33bac8f070] to [344503b49e].

︙
79
80
81
82
83
84
85
86

87
88
89
90
91
92
93

79
80
81
82
83
84
85

86
87
88
89
90
91
92
93








-
+








	XMPPRoster *roster;
}

#ifdef OF_HAVE_PROPERTIES
@property (copy) OFString *username, *password, *server, *domain, *resource;
@property (copy, readonly) XMPPJID *JID;
@property (assign) uint16_t port;
@property (retain) id <XMPPConnectionDelegate> delegate;
@property (assign) id <XMPPConnectionDelegate> delegate;
@property (readonly, retain) XMPPRoster *roster;
@property (readonly, retain, getter=socket) OFTCPSocket *sock;
@property (assign) BOOL encryptionRequired;
@property (readonly) BOOL encrypted;
#endif

/**
︙

Modified src/XMPPConnection.m from [19e1471872] to [cdb3217ac3].

︙
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91

77
78
79
80
81
82
83

84
85
86
87
88
89
90








-








	[elementBuilder release];
	[username release];
	[password release];
	[server release];
	[domain release];
	[resource release];
	[JID release];
	[delegate release];
	[authModule release];
	[bindID release];
	[sessionID release];
	[roster release];

	[super dealloc];
}
︙
891
892
893
894
895
896
897
898
899

900
901
902
903
904
905

906
907
908
909
910
911
912

890
891
892
893
894
895
896


897

898
899
900
901

902
903
904
905
906
907
908
909








-
-
+
-




-
+








- (uint16_t)port
{
	return port;
}

- (void)setDelegate: (id <XMPPConnectionDelegate>)delegate_
{
	id old = delegate;
	delegate = [(id)delegate_ retain];
	delegate = (id <XMPPConnectionDelegate, OFObject>)delegate_;
	[old release];
}

- (id <XMPPConnectionDelegate>)delegate
{
	return [[delegate retain] autorelease];
	return delegate;
}

- (XMPPRoster*)roster
{
	return [[roster retain] autorelease];
}
@end
︙