ObjXMPP  Check-in [2469a8df49]

Overview
Comment:Make sure all properties are nonatomic
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 2469a8df496bf6a20684d6b0ed1771f2e18cd8c4bb1d22139559f21168662c4b
User & Date: js on 2017-07-23 12:07:40
Other Links: manifest | tags
Context
2018-01-21
22:34
Update buildsys check-in: 4b47674079 user: js tags: trunk
2017-07-23
12:07
Make sure all properties are nonatomic check-in: 2469a8df49 user: js tags: trunk
11:57
Change documentation style to ObjFW's style check-in: 764c514b82 user: js tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Modified configure.ac from [6a4f3bf3d0] to [a7530af75e].

︙︙
20
21
22
23
24
25
26


27
28
29
30
31
32
33


CPP="$OBJCPP"
CPPFLAGS="$CPPFLAGS $OBJCPPFLAGS $($OBJFW_CONFIG --cppflags)"
OBJCFLAGS="$OBJCFLAGS -Wall $($OBJFW_CONFIG --objcflags)"
LDFLAGS="$LDFLAGS $($OBJFW_CONFIG --ldflags)"
LIBS="$LIBS $($OBJFW_CONFIG --libs)"



AX_CHECK_COMPILER_FLAGS(-Wdocumentation,
	[OBJCFLAGS="$OBJCFLAGS -Wdocumentation"])

AC_ARG_ENABLE(shared,
	AS_HELP_STRING([--disable-shared], [do not build shared library]))
AS_IF([test x"$enable_shared" != x"no"], [
	BUILDSYS_SHARED_LIB








>
>








20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35


CPP="$OBJCPP"
CPPFLAGS="$CPPFLAGS $OBJCPPFLAGS $($OBJFW_CONFIG --cppflags)"
OBJCFLAGS="$OBJCFLAGS -Wall $($OBJFW_CONFIG --objcflags)"
LDFLAGS="$LDFLAGS $($OBJFW_CONFIG --ldflags)"
LIBS="$LIBS $($OBJFW_CONFIG --libs)"

AX_CHECK_COMPILER_FLAGS(-Watomic-properties,
	[OBJCFLAGS="$OBJCFLAGS -Watomic-properties"])
AX_CHECK_COMPILER_FLAGS(-Wdocumentation,
	[OBJCFLAGS="$OBJCFLAGS -Wdocumentation"])

AC_ARG_ENABLE(shared,
	AS_HELP_STRING([--disable-shared], [do not build shared library]))
AS_IF([test x"$enable_shared" != x"no"], [
	BUILDSYS_SHARED_LIB
︙︙

Modified src/XMPPConnection.h from [0b78eccdeb] to [883bb55bc1].

︙︙
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259

 * The JID the server assigned to the connection after binding.
 */
@property (readonly, nonatomic) XMPPJID *JID;

/*!
 * The port to connect to.
 */
@property uint16_t port;

/*!
 * An object for data storage, conforming to the XMPPStorage protocol.
 */
@property OF_NULLABLE_PROPERTY (assign) id <XMPPStorage> dataStorage;

/*!
 * The socket used for the connection.
 */
@property (readonly, nonatomic) OFTCPSocket *socket;

/*!
 * Whether encryption is required.
 */
@property bool encryptionRequired;

/*!
 * Whether the connection is encrypted.
 */
@property (readonly) bool encrypted;

/*!
 * Whether roster versioning is supported.
 */
@property (readonly) bool supportsRosterVersioning;

/*!
 * Whether stream management is supported.
 */
@property (readonly) bool supportsStreamManagement;

/*!
 * Creates a new autoreleased XMPPConnection.
 *
 * @return A new autoreleased XMPPConnection
 */
+ (instancetype)connection;








|




|









|




|




|




|








215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259

 * The JID the server assigned to the connection after binding.
 */
@property (readonly, nonatomic) XMPPJID *JID;

/*!
 * The port to connect to.
 */
@property (nonatomic) uint16_t port;

/*!
 * An object for data storage, conforming to the XMPPStorage protocol.
 */
@property OF_NULLABLE_PROPERTY (nonatomic, assign) id <XMPPStorage> dataStorage;

/*!
 * The socket used for the connection.
 */
@property (readonly, nonatomic) OFTCPSocket *socket;

/*!
 * Whether encryption is required.
 */
@property (nonatomic) bool encryptionRequired;

/*!
 * Whether the connection is encrypted.
 */
@property (readonly, nonatomic) bool encrypted;

/*!
 * Whether roster versioning is supported.
 */
@property (readonly, nonatomic) bool supportsRosterVersioning;

/*!
 * Whether stream management is supported.
 */
@property (readonly, nonatomic) bool supportsStreamManagement;

/*!
 * Creates a new autoreleased XMPPConnection.
 *
 * @return A new autoreleased XMPPConnection
 */
+ (instancetype)connection;
︙︙

Modified src/XMPPDiscoEntity.h from [3c8c4b2136] to [2ffff60b5d].

︙︙
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63

/*!
 * @brief The XMPPDiscoNodes this entity provides Services Discovery
 *	  responses for
 *
 * This usually contains at least all immediate child nodes, but may contain
 * any number of nodes nested more deeply.
 */
@property (readonly) OFDictionary *discoNodes;

/*!
 * The node advertised for the entity's capabilites.
 */
@property (readonly) OFString *capsNode;

+ (instancetype)discoNodeWithJID: (XMPPJID *)JID
			    node: (nullable OFString *)node OF_UNAVAILABLE;
+ (instancetype)discoNodeWithJID: (XMPPJID *)JID
			    node: (nullable OFString *)node
			    name: (nullable OFString *)name OF_UNAVAILABLE;









|




|








44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63

/*!
 * @brief The XMPPDiscoNodes this entity provides Services Discovery
 *	  responses for
 *
 * This usually contains at least all immediate child nodes, but may contain
 * any number of nodes nested more deeply.
 */
@property (readonly, nonatomic) OFDictionary *discoNodes;

/*!
 * The node advertised for the entity's capabilites.
 */
@property (readonly, nonatomic) OFString *capsNode;

+ (instancetype)discoNodeWithJID: (XMPPJID *)JID
			    node: (nullable OFString *)node OF_UNAVAILABLE;
+ (instancetype)discoNodeWithJID: (XMPPJID *)JID
			    node: (nullable OFString *)node
			    name: (nullable OFString *)name OF_UNAVAILABLE;
︙︙

Modified src/XMPPMessage.h from [c8a8b87bf3] to [689e64d8e4].

︙︙
25
26
27
28
29
30
31

32

33
34
35
36
37
38
39
40


OF_ASSUME_NONNULL_BEGIN

/*!
 * @brief A class describing a message stanza.
 */
@interface XMPPMessage: XMPPStanza

/*! The text content of the body of the message. */

@property (copy) OFString *body;

/*!
 * @brief Creates a new autoreleased XMPPMessage.
 *
 * @return A new autoreleased XMPPMessage
 */
+ (instancetype)message;








>
|
>
|








25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42


OF_ASSUME_NONNULL_BEGIN

/*!
 * @brief A class describing a message stanza.
 */
@interface XMPPMessage: XMPPStanza
/*!
 * The text content of the body of the message.
 */
@property (nonatomic, copy) OFString *body;

/*!
 * @brief Creates a new autoreleased XMPPMessage.
 *
 * @return A new autoreleased XMPPMessage
 */
+ (instancetype)message;
︙︙

Modified src/XMPPRoster.h from [12b50e0f15] to [c49c440cdc].

︙︙
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82

	id <XMPPStorage> _dataStorage;
	bool _rosterRequested;
}

/*!
 * @brief The connection to which the roster belongs
 */
@property (readonly, assign) XMPPConnection *connection;

/*!
 * @brief An object for data storage, conforming to the XMPPStorage protocol.
 *
 * Inherited from the connection if not overridden.
 */
@property (nonatomic, assign) id <XMPPStorage> dataStorage;








|








68
69
70
71
72
73
74
75
76
77
78
79
80
81
82

	id <XMPPStorage> _dataStorage;
	bool _rosterRequested;
}

/*!
 * @brief The connection to which the roster belongs
 */
@property (readonly, nonatomic) XMPPConnection *connection;

/*!
 * @brief An object for data storage, conforming to the XMPPStorage protocol.
 *
 * Inherited from the connection if not overridden.
 */
@property (nonatomic, assign) id <XMPPStorage> dataStorage;
︙︙

Modified src/XMPPSRVLookup.h from [c9768d0ace] to [72a7f4de73].

︙︙
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51

	uint16_t _priority;
	uint16_t _weight;
	uint32_t _accumulatedWeight;
	uint16_t _port;
	OFString *_target;
}

@property (readonly) uint16_t priority;
@property (readonly) uint16_t weight;
@property uint32_t accumulatedWeight;
@property (readonly) uint16_t port;
@property (readonly, nonatomic) OFString *target;

+ (instancetype)entryWithPriority: (uint16_t)priority
			   weight: (uint16_t)weight
			     port: (uint16_t)port
			   target: (OFString *)target;
+ (instancetype)entryWithResourceRecord: (ns_rr)resourceRecord








|
|
|
|








34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51

	uint16_t _priority;
	uint16_t _weight;
	uint32_t _accumulatedWeight;
	uint16_t _port;
	OFString *_target;
}

@property (readonly, nonatomic) uint16_t priority;
@property (readonly, nonatomic) uint16_t weight;
@property (nonatomic) uint32_t accumulatedWeight;
@property (readonly, nonatomic) uint16_t port;
@property (readonly, nonatomic) OFString *target;

+ (instancetype)entryWithPriority: (uint16_t)priority
			   weight: (uint16_t)weight
			     port: (uint16_t)port
			   target: (OFString *)target;
+ (instancetype)entryWithResourceRecord: (ns_rr)resourceRecord
︙︙