CryptoPassphrase  Check-in [4a61a3ddab]

Overview
Comment:[iOS] Do not automatically set the focus

This is sometimes delayed a little and very confusing then.

Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 4a61a3ddab28d7f3251b2202abc10c1964bdff7b731d5344776da43ef887d244
User & Date: js 2019-01-22 23:42:10
Context
2019-06-16
05:25
iOS: Migrate to Swift check-in: 2c5f88ebb0 user: js tags: trunk
2019-01-22
23:42
[iOS] Do not automatically set the focus check-in: 4a61a3ddab user: js tags: trunk
23:35
[iOS] Use modules check-in: 604b510f98 user: js tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to iOS/ShowDetailsController.m.

︙︙
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54

{
	/*
	 * NSMutableString does not offer a way to zero the string.
	 * This is in the hope that setting a single character at an index just
	 * replaces that character in memory, and thus allows us to zero the
	 * password.
	 */
	for (NSUInteger i = 0 ; i < string.length; i++)
		[string replaceCharactersInRange: NSMakeRange(i, 1)
				      withString: @" "];
}

@implementation ShowDetailsController
- (void)dealloc
{








|








40
41
42
43
44
45
46
47
48
49
50
51
52
53
54

{
	/*
	 * NSMutableString does not offer a way to zero the string.
	 * This is in the hope that setting a single character at an index just
	 * replaces that character in memory, and thus allows us to zero the
	 * password.
	 */
	for (NSUInteger i = 0; i < string.length; i++)
		[string replaceCharactersInRange: NSMakeRange(i, 1)
				      withString: @" "];
}

@implementation ShowDetailsController
- (void)dealloc
{
︙︙
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105

	self.legacySwitch.on = _legacy;
	self.keyFileField.text = _keyFile.NSObject;

	[self.mainViewController.tableView deselectRowAtIndexPath: indexPath
							 animated: YES];
}

- (void)viewDidAppear: (BOOL)animated
{
	[super viewDidAppear: animated];

	[self.passphraseField becomeFirstResponder];
}

- (BOOL)textFieldShouldReturn: (UITextField *)textField
{
	[textField resignFirstResponder];
	return NO;
}

-	  (void)tableView: (UITableView *)tableView








<
<
<
<
<
<
<








85
86
87
88
89
90
91







92
93
94
95
96
97
98

	self.legacySwitch.on = _legacy;
	self.keyFileField.text = _keyFile.NSObject;

	[self.mainViewController.tableView deselectRowAtIndexPath: indexPath
							 animated: YES];
}








- (BOOL)textFieldShouldReturn: (UITextField *)textField
{
	[textField resignFirstResponder];
	return NO;
}

-	  (void)tableView: (UITableView *)tableView
︙︙