Differences From Artifact [2d0d3612cd]:
- File
iOS/ShowDetailsController.m
— part of check-in
[0ac34d09b9]
at
2017-10-15 22:36:46
on branch trunk
— Disable modules and force category references
Modules do not work well without frameworks. (user: js, size: 6867) [annotate] [blame] [check-ins using]
To Artifact [728614f00a]:
- File
iOS/ShowDetailsController.m
— part of check-in
[af661fbcc5]
at
2017-10-21 20:04:45
on branch trunk
— iOS: Get the length from the generator
This fixes reading over the buffer if it is not zero terminated.
Fortunately, this was almost always the case by pure luck. (user: js, size: 6926) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
196 197 198 199 200 201 202 |
@try {
[generator derivePassword];
} @finally {
of_explicit_memset(passphrase, 0, strlen(passphrase));
free(passphrase);
}
| | | > > | < | 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 |
@try {
[generator derivePassword];
} @finally {
of_explicit_memset(passphrase, 0, strlen(passphrase));
free(passphrase);
}
NSMutableString *password = [[[NSMutableString alloc]
initWithBytes: (char *)generator.output
length: generator.length
encoding: NSUTF8StringEncoding] autorelease];
of_explicit_memset(generator.output, 0, generator.length);
dispatch_sync(dispatch_get_main_queue(), ^ {
activityController.view.hidden = YES;
block(password);
});
});
}
|
| ︙ | ︙ |