Differences From Artifact [728614f00a]:
- File
iOS/ShowDetailsController.m
— part of check-in
[af661fbcc5]
at
2017-10-21 20:04:45
on branch trunk
— iOS: Get the length from the generator
This fixes reading over the buffer if it is not zero terminated.
Fortunately, this was almost always the case by pure luck. (user: js, size: 6926) [annotate] [blame] [check-ins using]
To Artifact [2b5b06f627]:
- File iOS/ShowDetailsController.m — part of check-in [6205c4feae] at 2017-11-26 19:19:07 on branch trunk — iOS: A few code modernizations (user: js, size: 6922) [annotate] [blame] [check-ins using]
︙ | ︙ | |||
73 74 75 76 77 78 79 | indexPath = self.mainViewController.tableView.indexPathForSelectedRow; [_name release]; _name = [self.mainViewController.sites[indexPath.row] retain]; _length = [siteStorage lengthForSite: _name]; _legacy = [siteStorage isSiteLegacy: _name]; | | | 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 | indexPath = self.mainViewController.tableView.indexPathForSelectedRow; [_name release]; _name = [self.mainViewController.sites[indexPath.row] retain]; _length = [siteStorage lengthForSite: _name]; _legacy = [siteStorage isSiteLegacy: _name]; self.nameField.text = _name.NSObject; self.lengthField.text = [NSString stringWithFormat: @"%zu", _length]; self.legacySwitch.on = _legacy; [self.mainViewController.tableView deselectRowAtIndexPath: indexPath animated: YES]; } |
︙ | ︙ | |||
178 179 180 181 182 183 184 | generator = [LegacyPasswordGenerator generator]; else generator = [NewPasswordGenerator generator]; generator.site = _name; generator.length = _length; | | | 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 | generator = [LegacyPasswordGenerator generator]; else generator = [NewPasswordGenerator generator]; generator.site = _name; generator.length = _length; passphrase = of_strdup(self.passphraseField.text.UTF8String); generator.passphrase = passphrase; mainStoryboard = [UIStoryboard storyboardWithName: @"Main" bundle: nil]; activityController = [mainStoryboard instantiateViewControllerWithIdentifier: @"activityIndicator"]; [self.navigationController.view addSubview: activityController.view]; |
︙ | ︙ |